You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/09 02:55:47 UTC
[GitHub] [netbeans] errael opened a new pull request, #4603: Keyboard focus can activate top component
errael opened a new pull request, #4603:
URL: https://github.com/apache/netbeans/pull/4603
Fix for #4437. Discussion in that issue is useful in understanding this patch.
`platform/core.windows` is a mystery to me; this patch is almost identical to getting a mouse click, except it is triggered by keyboard focus change to handle other situations where the MainWindow is activated. There may be better solutions, but I believe this is safe.
After getting a focus event, the activate code is only invoked when it is strictly needed. This is an optimization, invoking the activation code multiple times shouldn't matter; it would be like clicking on an already active window.
@jtulach, any idea for a good candidate to review this? This area was written by _Peter Zavadsky_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4603: Keyboard focus can activate top component
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4603:
URL: https://github.com/apache/netbeans/pull/4603#issuecomment-1252710077
I just tested this in a custom NetBeans build; the fix seems to work! Tested for correct active tab indication and Undo/Redo effect on Windows 11 with focus changed with Alt+Tab, Ctrl+Tab, clicking in Windows taskbar, clicking on tab within NetBeans, and clicking on window title bar.
I'll now leave this patch in my working IDE for a while to see that there are no problems.
Thanks for this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] errael commented on pull request #4603: Keyboard focus can activate top component
Posted by GitBox <gi...@apache.org>.
errael commented on PR #4603:
URL: https://github.com/apache/netbeans/pull/4603#issuecomment-1249509980
> The next time I make a private NetBeans build I'll include this patch and test it...
That would be great, I moved to linux last year, not tested on windows.
BTW, note that mouse click processing happens before keyboard focus change processing so this doesn't kick in when focus change due to mouse click.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #4603: Keyboard focus can activate top component
Posted by GitBox <gi...@apache.org>.
geertjanw merged PR #4603:
URL: https://github.com/apache/netbeans/pull/4603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4603: Keyboard focus can activate top component
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4603:
URL: https://github.com/apache/netbeans/pull/4603#issuecomment-1249478713
For others passing through, here is @neilcsmith-net's reproducibility comment from the other thread:
> Try detaching a source editor tab into a separate window and Alt-TABing between. The cursor moves from one editor to the other, but the window system active tab doesn't change - undo/redo is wrong, navigator is wrong, and wrong tab is coloured as focused. Typing goes in the right place, though.
I can confirm this on my own Windows 11 machine; this is obviously incorrect behavior. If the patch fixes this problem, then great; thank you!
Looking at the patch, it does carefully apply the modified behavior only in some specific cases, which should make it lower-risk. Looks good to me, but maybe good to have one more reviewer look at it.
The next time I make a private NetBeans build I'll include this patch and test it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists