[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #14158: Fix GHA workflows naming & Run ITs if UTs fail on coverage

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #14158:
URL: https://github.com/apache/druid/pull/14158#discussion_r1195141154


##########
.github/scripts/unit_tests_script.sh:
##########
@@ -24,7 +24,7 @@ MAVEN_OPTS='-Xmx2500m' ${MVN} test -pl ${MAVEN_PROJECTS} \
 ${MAVEN_SKIP} -Ddruid.generic.useDefaultValueForNull=${DRUID_USE_DEFAULT_VALUE_FOR_NULL}
 sh -c "dmesg | egrep -i '(oom|out of memory|kill process|killed).*' -C 1 || exit 0"
 free -m
-${MVN} -pl ${MAVEN_PROJECTS} jacoco:report
+${MVN} -pl ${MAVEN_PROJECTS} jacoco:report || { echo echo "coverage_failure=false" >> "$GITHUB_ENV" && false; }

Review Comment:
   echo echo? 



##########
.github/scripts/unit_tests_script.sh:
##########
@@ -70,7 +70,7 @@ then
   --log-template "totals-complete" \
   --log-template "errors" \
   -- ||
-  { printf "\n\n****FAILED****\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\nFor more details on how to run code coverage locally, follow instructions here - https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md#running-code-coverage-locally\n\n" && false; }
+  { printf "\n\n****FAILED****\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\nFor more details on how to run code coverage locally, follow instructions here - https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md#running-code-coverage-locally\n\n" && printf "test print\n" && echo "coverage_failure=true" >> "$GITHUB_ENV" && printf "test print2\n" && false; }

Review Comment:
   lot of test printing here. 



##########
.github/workflows/cron-job-its.yml:
##########
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-name: Cron Job ITs

Review Comment:
   whats the reason for these changes? 



##########
.github/workflows/unit-tests.yml:
##########
@@ -25,6 +26,16 @@ on:
         type: boolean
         default: true
         description: 'For SQL compatibility'
+    outputs:
+      continue_tests:
+        description: 'Flag to decide if phase 2 tests need to run incase coverage issue failures'

Review Comment:
   we are not using phase 1 / phase 2 terminology in GHA. 



##########
.github/workflows/reusable-standard-its.yml:
##########
@@ -89,7 +89,7 @@ jobs:
           ${MVN} verify -pl integration-tests -P integration-tests ${{ inputs.testing_groups }} -Djvm.runtime=${{ inputs.runtime_jdk }} -Dit.indexer=${{ inputs.use_indexer }} ${MAVEN_SKIP} -Doverride.config.path=${{ inputs.override_config_path }}
 
       - name: Debug IT
-        if: steps.run-it.conclusion == 'failure'
+        if: ${{ failure() && steps.run-it.conclusion == 'failure' }}

Review Comment:
   what's the reason behind this change? 



##########
.github/workflows/unit-tests.yml:
##########
@@ -50,7 +61,7 @@ jobs:
       sql_compatibility: ${{ inputs.sql_compatibility }}
       module: server
       maven_projects: 'server'
-
+#

Review Comment:
   leftover change? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org