You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/11/03 00:58:46 UTC

[kudu-CR] [test] shorter timeouts for client-negotiation-failover

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16692


Change subject: [test] shorter timeouts for client-negotiation-failover
......................................................................

[test] shorter timeouts for client-negotiation-failover

It's now possible to configure connection negotiation timeout in Kudu
C++ client (see KUDU-2966), and this patch uses the newly introduced
functionality to set shorter negotiation timeouts for all scenarios in
client-negotiation-failover-itest.  Doing so reduces the time spent
running the test.  Below are the results from the binary built in DEBUG
mode:

  KUDU_ALLOW_SLOW_TESTS=1 ./bin/client-negotiation-failover-itest

Before:
  [==========] 4 tests from 1 test case ran. (84445 ms total)
  [  PASSED  ] 4 tests.

After:
  [==========] 4 tests from 1 test case ran. (46295 ms total)
  [  PASSED  ] 4 tests.

Change-Id: Iabf7b6218b39c4348f87822218c3320949778cf9
---
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
1 file changed, 31 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/16692/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabf7b6218b39c4348f87822218c3320949778cf9
Gerrit-Change-Number: 16692
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [test] shorter timeouts for client-negotiation-failover

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16692 )

Change subject: [test] shorter timeouts for client-negotiation-failover
......................................................................

[test] shorter timeouts for client-negotiation-failover

It's now possible to configure connection negotiation timeout in Kudu
C++ client (see KUDU-2966), and this patch uses the newly introduced
functionality to set shorter negotiation timeouts for all scenarios in
client-negotiation-failover-itest.  Doing so reduces the time spent
running the test.  Below are the results from the binary built in DEBUG
mode:

  KUDU_ALLOW_SLOW_TESTS=1 ./bin/client-negotiation-failover-itest

Before:
  [==========] 4 tests from 1 test case ran. (84445 ms total)
  [  PASSED  ] 4 tests.

After:
  [==========] 4 tests from 1 test case ran. (46295 ms total)
  [  PASSED  ] 4 tests.

Change-Id: Iabf7b6218b39c4348f87822218c3320949778cf9
Reviewed-on: http://gerrit.cloudera.org:8080/16692
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
1 file changed, 31 insertions(+), 28 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf7b6218b39c4348f87822218c3320949778cf9
Gerrit-Change-Number: 16692
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [test] shorter timeouts for client-negotiation-failover

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16692 )

Change subject: [test] shorter timeouts for client-negotiation-failover
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf7b6218b39c4348f87822218c3320949778cf9
Gerrit-Change-Number: 16692
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Nov 2020 05:33:43 +0000
Gerrit-HasComments: No