[GitHub] [airflow] ashb edited a comment on pull request #12466: Adds support for Connection/Hook discovery from providers

[GitBox <gi...@apache.org>]

ashb edited a comment on pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#issuecomment-735373831


   > Just one last fixup - we had cyclic dependency Connection -> provider_manager -> plugins_manager -> Hook -> Connections. Solved it by extracting entrypoint_with_dist to a separate util module (as this is an util used by both plugins_manager and providers_manager now).
   
   Did something really detect that as a cycle? Cos importing `connection.py` would not cause the provider_manager to import anything from plugins_manager -- only running code would do that, not simply importing. Therefore that is not a cyclic import.
   
   (I'm okay with moving it to a separate module anyway, I was just being a little bit lazy last night when adding it. I'm still surprised that this was claimed to be a cycle though.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org