You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "zpinto (via GitHub)" <gi...@apache.org> on 2023/07/20 00:23:22 UTC
[GitHub] [helix] zpinto opened a new pull request, #2566: helix-rest parallel stoppable instances zone_order re-order fix
zpinto opened a new pull request, #2566:
URL: https://github.com/apache/helix/pull/2566
Fix for parallel instances stoppable API reordering the zoneList when a user provides their own zone_order.
### Issues
- NA/new issue
### Description
When a user provides their own zone_order when using the parallel instances stoppable API in helix-rest, that order should be respected when selecting the zone to check. This will fix that by ensuring the provided zone_order is not alphabetically re-ordered as it is when a zone_order is not provided.
### Tests
- [x] TestInstancesAccessor#testInstanceStoppable_zoneBased_zoneOrder
- Ensures that zone2 is selected when provided a zone_order of zone2,zone1
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- NA
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zpinto commented on pull request #2566: helix-rest parallel stoppable instances zone_order re-order fix
Posted by "zpinto (via GitHub)" <gi...@apache.org>.
zpinto commented on PR #2566:
URL: https://github.com/apache/helix/pull/2566#issuecomment-1644613095
This PR is ready to be merged
Final Commit Message:
Fix for parallel instances stoppable API incorrectly reordering the zoneList when a user provides their own zone_order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2566: helix-rest parallel stoppable instances zone_order re-order fix
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2566:
URL: https://github.com/apache/helix/pull/2566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org