You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Edward Ribeiro (JIRA)" <ji...@apache.org> on 2015/07/10 02:12:05 UTC
[jira] [Comment Edited] (SOLR-7705) CoreAdminHandler Unload no
longer handles null core name.
[ https://issues.apache.org/jira/browse/SOLR-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621471#comment-14621471 ]
Edward Ribeiro edited comment on SOLR-7705 at 7/10/15 12:11 AM:
----------------------------------------------------------------
Hi, I have attached a patch. Please, let me know what you think.
ps: the patch is against lucene_solr_5_0 since lucene_solr_4_10 involves some more changes, but I can backport it to 4.9 too if you feel like doing it.
Cheers,
Eddie
was (Author: eribeiro):
Hi, I am have attached a patch. It's against lucene_solr_5_0 since lucene_solr_4_10 involves some more changes, but I can backport it to 4.9 too if you feel like doing it. Please, see if the patch fits.
> CoreAdminHandler Unload no longer handles null core name.
> ---------------------------------------------------------
>
> Key: SOLR-7705
> URL: https://issues.apache.org/jira/browse/SOLR-7705
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.10, 5.0, 5.1, 5.2
> Environment: Windows 8 and Windows Server 2012 R2
> Reporter: John Call
> Priority: Minor
> Labels: easyfix
> Fix For: 4.10, 5.0, 5.1, 5.2, Trunk
>
> Attachments: SOLR-7705.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Pre 4.10 If a null core name was passed in it would be handled as a bad request with error message "No such core exists [ null ]". From 4.10 onwards an unload call goes to CoreContainer unload where the first action taken is removing the core from coreInitFailures which throws when given null and instead of returning the expected BadRequest "Cannot unload non-existent core [null]" it returns InternalServerError "java.lang.NullPointerException
> at java.util.concurrent.ConcurrentHashMap.replaceNode(Unknown Source)
> at java.util.concurrent.ConcurrentHashMap.remove(Unknown Source)
> at org.apache.solr.core.CoreContainer.unload(CoreContainer.java:661)..."
> This was found due to mixing up query parameter "name" used in create vs "core" in unload. As a result this is easily reproducible with http://localhost:8983/solr/admin/cores?action=UNLOAD&name=core0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org