[GitHub] [arrow] AlenkaF commented on a diff in pull request #14662: GH-31905: [DevTools] Add linting to Cython files

["AlenkaF (via GitHub)" <gi...@apache.org>]

AlenkaF commented on code in PR #14662:
URL: https://github.com/apache/arrow/pull/14662#discussion_r1118394041


##########
.pre-commit-config.yaml:
##########
@@ -47,3 +47,8 @@ repos:
           - python
         exclude: vendored
         args: [--config, python/setup.cfg]
+  - repo: https://github.com/MarcoGorelli/cython-lint
+    rev: v0.12.4
+    hooks:
+      - id: cython-lint
+        args: [--max-line-length=120]

Review Comment:
   I would suggest making the docstring example data smaller, like so:
   
   ```python
   >>> import pyarrow as pa
   >>> n_legs = pa.array([2, 4, 100])
   >>> names = ["n_legs", "animals"]
   >>> batch = pa.record_batch([n_legs, animals], names=names)
   >>> batch.to_pandas()
   Construct a Table   n_legs    animals
   0       2   Flamingo
   1       4      Horse
   2     100  Centipede
   
   Construct a Table from a RecordBatch:
   
   >>> pa.Table.from_batches([batch])
   pyarrow.Table
   n_legs: int64
   animals: string
   ----
   n_legs: [[2,4,100]]
   animals: [["Flamingo","Horse","Centipede"]]
   
   Construct a Table from a sequence of RecordBatches:
   
   >>> pa.Table.from_batches([batch, batch])
   pyarrow.Table
   n_legs: int64
   animals: string
   ----
   n_legs: [[2,4,100],[2,4,100]]
   animals: [["Flamingo","Horse","Centipede"],["Flamingo","Horse","Centipede"]]
   ```
   I think that should get under the limit of 88.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org