[GitHub] [incubator-echarts] pissang edited a comment on pull request #13094: Fix legend color with customized itemStyle

[GitBox <gi...@apache.org>]

pissang edited a comment on pull request #13094:
URL: https://github.com/apache/incubator-echarts/pull/13094#issuecomment-673278481


   <del>I'm not sure, but is it relevant to @Ovilia 's PR https://github.com/apache/incubator-echarts/pull/12444 ?</del>
   
   Had a further review. Seems it's trying to solve the same issue at https://github.com/apache/incubator-echarts/pull/12133 from @susiwen8 .
   
   I remember we had a discussion privately about how should we choose the color of the legend if `itemStyle.color` is a callback.
   
   I preferred choosing the first color callback given, which is the same strategy in this PR. But @100pah thought it will be misleading if the callback returns several different colors and choose the color from the default palette.
   
   My opinion is still not changed. The misleading is much less than the current strategy if we choose the color from callback returns.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org