You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/06/12 09:40:29 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations
AngersZhuuuu opened a new pull request, #1578:
URL: https://github.com/apache/incubator-celeborn/pull/1578
### What changes were proposed in this pull request?
Unify exclude and blacklist related configurations
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations and variables
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu closed pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations and variables
URL: https://github.com/apache/incubator-celeborn/pull/1578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1578:
URL: https://github.com/apache/incubator-celeborn/pull/1578#issuecomment-1586986277
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1578](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e63f5e4) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3c7d179e051dce1dc4cf3a559a6761eadeccd9a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c7d179) will **decrease** coverage by `0.79%`.
> The diff coverage is `83.34%`.
```diff
@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
- Coverage 46.21% 45.42% -0.79%
==========================================
Files 158 158
Lines 9958 9830 -128
Branches 967 968 +1
==========================================
- Hits 4601 4464 -137
- Misses 5055 5064 +9
Partials 302 302
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.14% <83.34%> (-0.77%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1578/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations and variables
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1578:
URL: https://github.com/apache/incubator-celeborn/pull/1578#issuecomment-1594484320
I perfer merge https://github.com/apache/incubator-celeborn/pull/1588 before this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations and variables
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1578:
URL: https://github.com/apache/incubator-celeborn/pull/1578#issuecomment-1587015491
ping @waitinfuture @FMX @RexXiong @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1578: [CELEBORN-666][REFACTOR] Unify exclude and blacklist related configurations and variables
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1578:
URL: https://github.com/apache/incubator-celeborn/pull/1578#issuecomment-1587049869
The change makes sense to me, better to get approval by @waitinfuture before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org