You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/05 06:14:38 UTC

[GitHub] [calcite] hsyuan commented on pull request #1995: [CALCITE-4012] Implement trait propagation for EnumerableHashJoin and…

hsyuan commented on pull request #1995:
URL: https://github.com/apache/calcite/pull/1995#issuecomment-639281013


   > Based on examples of MergeJoin, seems like the goal of trait derivation was to enforce a sort on right input, which does not work for hashjoin and nested loop join in this case.
   
   This is incorrect. `derive()` is used to derived new traits from child trait, just like project, filter. MergeJoin is different, because it requires both sides sorted on the same keys.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org