You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/04/25 09:44:02 UTC
[GitHub] [hive] amanraj2520 opened a new pull request, #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
amanraj2520 opened a new pull request, #4264:
URL: https://github.com/apache/hive/pull/4264
JIRA link : https://issues.apache.org/jira/browse/HIVE-27292
Zookeper 3.6.3 is End of Life (https://endoflife.date/zookeeper)
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1522296277
Agree with your points. Let's merge this one, because we could just win with this, and let's have a follow up PR with 3.8.1.
Btw: 3.7 was even bigger release :) But I guess it should work, as I remember we did not had to many problem with zookeeper versions in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1525848855
@amanraj2520 should we wait for https://github.com/apache/hive/pull/4270? I've just re-triggered it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1522812874
@TuroczyX Raised this draft PR - https://github.com/apache/hive/pull/4270. Will upgrade it after testing. Meanwhile if this 3.7.1 change looks good to you can you please approve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1521765614
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4264)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4264&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4264&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4264&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4264&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4264&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4264&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1521774166
The change is legit, but won't be better to go to 3.8.1?
3.7.1 will be deprecated 2 weeks from now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1528778086
@deniskuzZ I think there are some legitimate failures in https://github.com/apache/hive/pull/4270 so don't think we should wait for that one; it can go in when its ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rakeshadr commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "rakeshadr (via GitHub)" <gi...@apache.org>.
rakeshadr commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1527129517
> Agree with your points. Let's merge this one, because we could just win with this, and let's have a follow up PR with 3.8.1.
>
> Btw: 3.7 was even bigger release :) But I guess it should work, as I remember we did not had to many problem with zookeeper versions in the past.
>
> PS: With a draft PR we can try it out quickly the 3.8
Hi [aturoczy](https://github.com/aturoczy),
I agree to move to 3.8.1.
On the other side, I'd really appreciate if you could give references about the 3.7.1 deprecation plans. I could see https://zookeeper.apache.org/releases.html still says that 3.7.1 is a stable release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1529905404
Late into the party. But for the fact, it isn't zookeeper upgrades are too calm, actually none of the dependency upgrades are calm. ex. Hadoop's Zookeeper upgrade to 3.8.1 is in a mess : https://github.com/apache/hadoop/pull/5345
btw. do we plan to upgrade curator as well to 5.4.0? that seems to be the one supporting zk 3.7.1([CURATOR-596](https://issues.apache.org/jira/browse/CURATOR-596)), good to do so if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aturoczy commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "aturoczy (via GitHub)" <gi...@apache.org>.
aturoczy commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1529163025
@rakeshadr I track the libs / components lifecycle on this page. https://endoflife.date/zookeeper
It is pretty accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1522112435
@TuroczyX I agree we can upgrade to 3.8.x but according to me it will be a major version upgrade and it would require some time to test it. Personally, I do not have an issue with this, it is just that I have run all the tests in my local keeping 3.7.1 in mind. I suggest that we can create a follow up ticket to upgrade it to 3.8.x. But if the community agrees, I can bump it to 3.8.x. Let me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1523210096
@deniskuzZ Could you please check and if it is ok merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
URL: https://github.com/apache/hive/pull/4264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4264: HIVE-27292 : Upgrade Zookeeper to 3.7.1
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4264:
URL: https://github.com/apache/hive/pull/4264#issuecomment-1527920882
@zabetak @ayushtkn @abstractdog Can we please merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org