[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #1738: add bloom filter index
URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322046176
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
 ##########
 @@ -152,7 +153,12 @@ class BinaryPlainPageDecoder : public PageDecoder {
 
         // Decode trailer
         _num_elems = decode_fixed32_le((const uint8_t *)&_data[_data.get_size() - sizeof(uint32_t)]);
-        _offsets_pos = _data.get_size() - (_num_elems + 1) * sizeof(uint32_t);
+        uint32_t tail_length = (_num_elems + 1) * sizeof(uint32_t);
+        if (_data.get_size() <= tail_length) {
 
 Review comment:
   if `_num_elems == 0`, then `_data.get_size() == tail_length` is valid

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org