[GitHub] [arrow] pitrou commented on a change in pull request #11591: ARROW-12163: [Java] Make compression levels configurable.

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #11591:
URL: https://github.com/apache/arrow/pull/11591#discussion_r741887094



##########
File path: docs/source/java/ipc.rst
##########
@@ -54,6 +54,15 @@ Now, we can begin writing a stream containing some number of these batches. For
     ArrowStreamWriter writer = new ArrowStreamWriter(root, /*DictionaryProvider=*/null, Channels.newChannel(out));
 
 
+Buffer level compression is also supported by passing a codec:
+Lz4CompressionCodec / ZstdCompressionCodec:
+
+.. code-block:: Java
+
+    ArrowStreamWriter writer = new ArrowStreamWriter(schemaRootWrite, true, new Lz4CompressionCodec(), true,
+        null, fileOutputStream.getChannel());

Review comment:
       "true, null" doesn't say much about what these parameters are. Should you add commented parameter names as above (e.g. `/*DictionaryProvider=*/null`, but I don't know if it's the right name here?).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org