You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/09/16 07:04:48 UTC

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

GitHub user minahlee opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/309

    [ZEPPELIN-309] Redirect to created/cloned notebook page on notebook c…

    …reation/clone
    
    This PR enables redirecting to new/cloned notebook pages when create/clone notebook event occurs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-309

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #309
    
----
commit a3c65c388309498afc4b93e19981992b57e4ce2d
Author: Mina Lee <mi...@nflabs.com>
Date:   2015-09-16T04:31:05Z

    [ZEPPELIN-309] Redirect to created/cloned notebook page on notebook creation/clone

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-155045488
  
    @Leemoonsoo Rebased master branch and pushed a fix for CI test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-155057304
  
    Tested, working well. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/309


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-154727314
  
    This PR i think need to be rebased. also need to change test to make CI test pass. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-140650954
  
    I always thought this feature should be done using RestApi so that you don't get any websocket message, but this is somehow working without any problem.
    
    However the event we rely on in this PR is pretty much not needed originally.
    `` broadcastNote(newNote);`` should not be called in the case of a createNewNote or CopyNote.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-309] Redirect to create...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/309#issuecomment-154726309
  
    I think it's okay to use websocket, while this implementation does not adds more complexity (ie. new websocket message) and it's more consistent to keep using websocket for notebook operations in webapp.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---