You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/01 09:48:00 UTC

[jira] [Commented] (GROOVY-8670) Make groovy-bsf an optional "module" for 2.5.1+, i.e. not reference by groovy-all

    [ https://issues.apache.org/jira/browse/GROOVY-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529031#comment-16529031 ] 

ASF GitHub Bot commented on GROOVY-8670:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/763

    GROOVY-8670: Make groovy-bsf an optional "module" for 2.5.1+, i.e. no…

    …t reference by groovy-all

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8670

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #763
    
----
commit 4bf127fcc3e592a4540e3425865a8cd8320dde6a
Author: Paul King <pa...@...>
Date:   2018-07-01T09:45:11Z

    GROOVY-8670: Make groovy-bsf an optional "module" for 2.5.1+, i.e. not reference by groovy-all

----


> Make groovy-bsf an optional "module" for 2.5.1+, i.e. not reference by groovy-all
> ---------------------------------------------------------------------------------
>
>                 Key: GROOVY-8670
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8670
>             Project: Groovy
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>              Labels: breaking
>             Fix For: 2.5.1
>
>
> The groovy-all dependency brings in all the common "modules" for Groovy. I don't think groovy-bsf is in common use any more. Plus the transitive bsf jar dependency isn't OSGi complaint which breaks* OSGi builds wanting to use the groovy-all dependency. Users needing bsf can simply add that dependency to their build.
>  [*] Provides an annoying warning at least.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)