[GitHub] [airflow] potiuk commented on pull request #22941: Allow re-use of decorated tasks

[GitBox <gi...@apache.org>]

potiuk commented on PR #22941:
URL: https://github.com/apache/airflow/pull/22941#issuecomment-1098587929

   > It’s a nice feature but I don’t quite buy the syntax. The `hello` takes no arguments, making it magically possible to accept `task_id` does not seem to mesh well with the initial design. It would not work well with type-checking DAG files, if I understand correctly.
   
   I personally like the `override` syntax even if it is already possible with task(hello).  It's more consistent - using decorators for both dag and task make more sene - task(hello, ..) is not obvious at all - unless you know details how the decorator is implemented - most users will not actually go as far as trying to understand what it does under-the-hood, they just now that task can be created by @task decorating a function and then calling the function within @dag decorated one. The override is more "obvious" imho. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org