You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/28 16:17:34 UTC

[GitHub] [cordova-ios] 75341704 opened a new issue #924: RE: WkWebView full Screen in iphone X

75341704 opened a new issue #924:
URL: https://github.com/apache/cordova-ios/issues/924


   # Feature Request
   WkWebView full Screen in iphone X 
   
   ## Motivation Behind Feature
   <!-- Why should this feature be implemented? What problem does it solve? -->
   Get full cover in the iphone.
   
   Use safe-area-inset-*  instead to handle the notch  
   
   
   ## Feature Description
   <!-- 
   Describe your feature request in detail
   Please provide any code examples or screenshots of what this feature would look like
   Are there any drawbacks? Will this break anything for existing users? 
   -->
   
   
   ## Alternatives or Workarounds
   <!-- 
   Describe alternatives or workarounds you are currently using 
   Are there ways to do this with existing functionality?
   -->
   //Append the code in CDVWebViewEngine.m
   //line no:205
       #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000
       if (@available(iOS 11.0, *)) {
         [wkWebView.scrollView setContentInsetAdjustmentBehavior:UIScrollViewContentInsetAdjustmentNever];
       }
       #endif
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue commented on issue #924: RE: WkWebView full Screen in iphone X

Posted by GitBox <gi...@apache.org>.
dpogue commented on issue #924:
URL: https://github.com/apache/cordova-ios/issues/924#issuecomment-650889766


   Control of safe-area-insets should be up to the application author to determine with the `viewport-fit=cover` meta directive.
   
   Cordova will not take that control away from application authors by enforcing particular viewport behaviour.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue closed issue #924: RE: WkWebView full Screen in iphone X

Posted by GitBox <gi...@apache.org>.
dpogue closed issue #924:
URL: https://github.com/apache/cordova-ios/issues/924


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org