You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/30 03:43:46 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
HyukjinKwon opened a new pull request #30198:
URL: https://github.com/apache/spark/pull/30198
### What changes were proposed in this pull request?
This PR proposes to switch the class loader strategy from `ScalaLibrary` to `Flat` (see https://www.scala-sbt.org/1.x/docs/In-Process-Classloaders.html). See also https://github.com/sbt/sbt/issues/5736
### Why are the changes needed?
To make the build unflaky.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
GitHub Actions build in this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719326645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130437/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719367461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719324242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719425435
@maropu, I am not very sure. From reading the doc, seems it dose because it will change a class loader, within SBT, that is used during `test` tasks. I think the SBT maintainer suggested this way because he suspects that there's something wrong in the reused class loader. So by changing it to `Flat`, it won't be reused anymore.
Ideally it should not have any behaviour change even with the default `ScalaLibrary` but seems it did (?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719159577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719431198
Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release (in terms of JDK, not Hive or Hadoop versions), that is built by JDK 8, that can run on both JDK 8 and JDK 11.
GitHub Actions has a job that builds it with JDK 11 but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719431198
Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release (in terms of JDK, not Hive or Hadoop versions), that is built by JDK 8, that can run on both JRE 8 and JRE 11.
GitHub Actions has a job that compiles it with JDK 11 (without running tests) but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719427691
I ran the build 15 times. Meaning 150 times compilation, and I don't see the same error anymore. Other errors look something already going on without this PR.
I am going to merge this.. let's see how it goes.
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719367493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35048/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719170248
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719425435
@maropu, I am not very sure. From reading the doc, seems it dose because it will change a class loader, within SBT, that is used during `test` tasks. I think the SBT maintainer suggested this way by suspecting that there's something wrong in the reused class loader. So by changing it to `Flat`, it won't be reused anymore.
Ideally it should not have any behaviour change even with the default `ScalaLibrary` but seems it did (?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719342926
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-727917492
Thanks @MaxGekk. It became less frequent given my observation but maybe I was wrong. I will check the builds tomorrow more closely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719193825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719427691
I ran the build 15 times. Meaning 150 times build, and I don't see the same error anymore. Other errors look something already going on without this PR.
I am going to merge this.. let's see how it goes.
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-727916511
I still observe the issue in https://github.com/apache/spark/pull/30377/checks?check_run_id=1405697533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719323867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719168632
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35042/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719256412
@dongjoon-hyun, @maropu, @gengliangwang, @gemelen, could we merge this and see how it goes if the tests pass?
Seems 5 consecutive builds passed without that issue - I retriggered 5 more builds again just for doubly sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719170252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35041/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719170248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719193767
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35042/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719431198
Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release (in terms of JDK, not Hive or Hadoop versions), that is built by JDK 8, that also works on both JDK 8 and JDK 11.
GitHub Actions has a job that builds it with JDK 11 but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719431198
Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release, that is built by JDK 8, that also works on both JDK 8 and JDK 11.
GitHub Actions has a job that builds it with JDK 11 but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719159577
**[Test build #130437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130437/testReport)** for PR 30198 at commit [`57606c7`](https://github.com/apache/spark/commit/57606c7a2288db306d5abfe31bd51df956ae1d6d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719304451
looks fine. just out of curiosity; this strategy change doesn't affects test running time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gemelen commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
gemelen commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719428339
Won't it be useful to guard this setting with condition to use only on JVM earlier than 11 then?
// Seems I'm a bit late with that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719193825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719330937
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719170235
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719288864
**[Test build #130443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130443/testReport)** for PR 30198 at commit [`866a02e`](https://github.com/apache/spark/commit/866a02eb5d2a3acdb5d198cac67b899243af1d68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719324275
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130443/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719155376
**[Test build #130436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130436/testReport)** for PR 30198 at commit [`68115b5`](https://github.com/apache/spark/commit/68115b50175fcd1d0dec28fe358984432a1dbc6e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30198:
URL: https://github.com/apache/spark/pull/30198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719367385
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719326640
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719330937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719324242
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719367461
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719330939
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130436/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719326640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719431198
Oh, @gemelen. Yeah that would have been better. But it's okay because currently there is only one Spark in the release (in terms of JDK, not Hive or Hadoop versions), that is built by JDK 8, that can run on both JRE 8 and JRE 11.
GitHub Actions has a job that builds it with JDK 11 but that's more about a sanity check so we can easily drop JDK 8 and move to JDK 11 later. I think we can just remove this out when we migrate to JDK 11 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719164008
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org