[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

[GitBox <gi...@apache.org>]

imjoey commented on a change in pull request #1446:
URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571531652



##########
File path: api/test/shell/manager_smoking.sh
##########
@@ -52,6 +52,12 @@ else
 	    echo "no Version output"
 	    exit 1
 	fi
+   # Version output

Review comment:
       Please fix code style here.

##########
File path: api/VERSION
##########
@@ -1 +1 @@
-master
+2.3

Review comment:
       @nic-chen  Any reason to change this to `2.3`? IMHO, we shall keep using `master` in master branch.

##########
File path: Dockerfile
##########
@@ -19,9 +19,10 @@ FROM alpine:latest as pre-build
 ARG APISIX_DASHBOARD_VERSION=master
 
 RUN set -x \
-    && wget https://github.com/apache/apisix-dashboard/archive/${APISIX_DASHBOARD_VERSION}.tar.gz -O /tmp/apisix-dashboard.tar.gz \
-    && mkdir /usr/local/apisix-dashboard \
-    && tar -xvf /tmp/apisix-dashboard.tar.gz -C /usr/local/apisix-dashboard --strip 1
+    && apk add --no-cache --virtual .builddeps git \
+    && git clone https://github.com/apache/apisix-dashboard.git -b ${APISIX_DASHBOARD_VERSION} /usr/local/apisix-dashboard \
+    && cd /usr/local/apisix-dashboard && git clean -Xdf \
+	&& rm -f ./.githash && git log --pretty=format:"%h" -1 > ./.githash

Review comment:
       Please fix code style here. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org