You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/05/14 13:27:43 UTC

[isis] branch master updated: ISIS-2666: just comments

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new a7ec5a0  ISIS-2666: just comments
a7ec5a0 is described below

commit a7ec5a0f54e74404a778c246d3cbe2d77e436a10
Author: ahuber@apache.org <ah...@luna>
AuthorDate: Fri May 14 15:27:31 2021 +0200

    ISIS-2666: just comments
---
 .../apache/isis/testdomain/interact/SimulatedUiChoices.java  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/regressiontests/stable-interact/src/test/java/org/apache/isis/testdomain/interact/SimulatedUiChoices.java b/regressiontests/stable-interact/src/test/java/org/apache/isis/testdomain/interact/SimulatedUiChoices.java
index 96373ab..4bb0479 100644
--- a/regressiontests/stable-interact/src/test/java/org/apache/isis/testdomain/interact/SimulatedUiChoices.java
+++ b/regressiontests/stable-interact/src/test/java/org/apache/isis/testdomain/interact/SimulatedUiChoices.java
@@ -43,9 +43,6 @@ public class SimulatedUiChoices extends HasValueValidation {
 
     @Override
     public void bind(ManagedValue managedValue) {
-
-        val choices = managedValue.getChoices();
-
         choiceBox.bind(managedValue.getChoices());
         choiceBox.addListener((e,o,n)->{
             choiceBoxUpdateEventCount.increment();
@@ -64,11 +61,18 @@ public class SimulatedUiChoices extends HasValueValidation {
         bind(pendingArgs.getParamModels().getElseFail(paramNr));
     }
 
+    /**
+     * assuming the parameter is a scalar type
+     * @param choiceIndex
+     */
     public void simulateChoiceSelect(int choiceIndex) {
         selectedItem.setValue(choiceBox.getValue().getElseFail(choiceIndex));
     }
 
-    // assuming the parameter is a non-scalar type
+    /**
+     * assuming the parameter is a non-scalar type
+     * @param choiceIndices
+     */
     public void simulateMultiChoiceSelect(int ... choiceIndices) {
         val newValuePojos = choiceBox.getValue()
                 .pickByIndex(choiceIndices)