You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/07/13 15:31:48 UTC

[GitHub] flink pull request #4323: [FLINK-7175] Add first simplest Flink benchmark

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4323

    [FLINK-7175] Add first simplest Flink benchmark

    Example output:
    
    ```
    Benchmark                           (objectReuse)  (parallelism)  (stateBackend)   Mode  Cnt     Score     Error   Units
    EventCountBenchmark.benchmarkCount           true              1          memory  thrpt    5  4433.286 ± 777.338  ops/ms
    EventCountBenchmark.benchmarkCount           true              1           rocks  thrpt    5   569.078 ±  15.298  ops/ms
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink benchmarks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4323
    
----
commit af6ea42ecdac723cef36f9d994cac3c680114ddd
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-07-05T11:39:20Z

    [FLINK-7175] Add first simplest Flink benchmark
    
    Example output:
    
    Benchmark                           (objectReuse)  (parallelism)  (stateBackend)   Mode  Cnt     Score     Error   Units
    EventCountBenchmark.benchmarkCount           true              1          memory  thrpt    5  4433.286 ± 777.338  ops/ms
    EventCountBenchmark.benchmarkCount           true              1           rocks  thrpt    5   569.078 ±  15.298  ops/ms

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4323: [FLINK-7175] Add first simplest Flink benchmark

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4323
  
    Another idea: a separate repo but never released since this looks to be for observation by developers rather than the community at large (results could be summarized in the documentation).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4323: [FLINK-7175] Add first simplest Flink benchmark

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4323
  
    Thanks for pointing this out. Indeed we will probably have to move it to separate project in that case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4323: [FLINK-7175] Add first simplest Flink benchmark

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4323
  
    Closing this PR. Benchmarks will be in separate repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4323: [FLINK-7175] Add first simplest Flink benchmark

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4323
  
    JMH's GPLv2 license is not compatible with the ASL (see 2063fa12)? This would need to be a separate repo distinct from the Apache Flink project and licensed under the GPL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4323: [FLINK-7175] Add first simplest Flink benchmark

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski closed the pull request at:

    https://github.com/apache/flink/pull/4323


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---