You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2013/12/17 06:54:10 UTC
[jira] [Comment Edited] (HBASE-10137) GeneralBulkAssigner with
retain assignment plan can be used in EnableTableHandler to bulk assign the
regions
[ https://issues.apache.org/jira/browse/HBASE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850137#comment-13850137 ]
Jimmy Xiang edited comment on HBASE-10137 at 12/17/13 5:52 AM:
---------------------------------------------------------------
[~stack], do you mean GeneralBulkAssigner? There is no GeneralBulkEnabler. GeneralBulkAssigner is for assignment. The base class is called BulkAssigner. So we can't call it BulkAssigner again. Calling it BulkEnabler probably is not good either since it is not just enabling a table, compared to the original BulkEnabler, and the existing BulkDisabler.
[~rajesh23], renaming GeneralBulkAssigner to BulkEnabler seems not so good. What other name can we use?
was (Author: jxiang):
@stack, do you mean GeneralBulkAssigner? There is no GeneralBulkEnabler. GeneralBulkAssigner is for assignment. The base class is called BulkAssigner. So we can't call it BulkAssigner again. Calling it BulkEnabler probably is not good either since it is not just enabling a table, compared to the original BulkEnabler, and the existing BulkDisabler.
[~rajesh23], renaming GeneralBulkAssigner to BulkEnabler seems not so good. What other name can we use?
> GeneralBulkAssigner with retain assignment plan can be used in EnableTableHandler to bulk assign the regions
> ------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-10137
> URL: https://issues.apache.org/jira/browse/HBASE-10137
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 0.96.0, 0.94.14
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.98.0, 0.96.2, 0.99.0
>
> Attachments: HBASE-10137.patch, HBASE-10137_v2.patch
>
>
> Current in BulkEnabler we are assigning one region at a time, instead we can use GeneralBulkAssigner to bulk assign multiple regions at a time.
> {code}
> for (HRegionInfo region : regions) {
> if (assignmentManager.getRegionStates()
> .isRegionInTransition(region)) {
> continue;
> }
> final HRegionInfo hri = region;
> pool.execute(Trace.wrap("BulkEnabler.populatePool",new Runnable() {
> public void run() {
> assignmentManager.assign(hri, true);
> }
> }));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)