You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/11/13 18:30:55 UTC
[PR] [Draft][Unity][Transform] Extract partial-tuple-usage from FuseOps [tvm]
Lunderberg opened a new pull request, #16119:
URL: https://github.com/apache/tvm/pull/16119
Prior to this commit, the `FuseOps` pass explicitly tracked usage of
tuple arguments, to minimize the set of arguments provided to each
kernel. The additional tgracking and handling of partially-used
tuples makes it difficult to follow the primary changes being made by
`FuseOps`.
This commit implements the same functionality in terms of the
`ExpandTupleArguments` and `RemoveUnusedParameters` transforms,
introduced in https://github.com/apache/tvm/pull/16115 and
https://github.com/apache/tvm/pull/16116 respectively. By using these
passes before the main `FuseOps` changes, partial tuple usage is
already handled at that point.
This commit is intended to minimize any changes to user-facing
behavior, and so these pre-process passes are currently used
internally by `FuseOps`. This may be avoided in the future by pulling
this internal delegation out into a lowering pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Draft][Unity][Transform] Extract partial-tuple-usage from FuseOps [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #16119:
URL: https://github.com/apache/tvm/pull/16119#issuecomment-1808783623
This PR is marked as a draft, until the pre-requisite PRs #16115, #16116, #16117, and #16118 land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity][Transform] Extract partial-tuple-usage from FuseOps [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #16119: [Unity][Transform] Extract partial-tuple-usage from FuseOps
URL: https://github.com/apache/tvm/pull/16119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity][Transform] Extract partial-tuple-usage from FuseOps [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #16119:
URL: https://github.com/apache/tvm/pull/16119#issuecomment-1836828613
All prerequisite PRs have now landed, and this PR is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity][Transform] Extract partial-tuple-usage from FuseOps [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #16119:
URL: https://github.com/apache/tvm/pull/16119#issuecomment-1877836986
Failing unit tests are due to MSC relying on relax variable names being preserved. https://github.com/apache/tvm/pull/16349 is submitted to fix these unit tests, after which CI can be re-run for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org