[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #530: [ISSUE #525][operator] refine svc creations

["wangao1236 (via GitHub)" <gi...@apache.org>]

wangao1236 commented on code in PR #530:
URL: https://github.com/apache/incubator-uniffle/pull/530#discussion_r1096891366


##########
deploy/kubernetes/operator/pkg/webhook/inspector/rss.go:
##########
@@ -148,8 +148,10 @@ func generateRSSPatches(ar *admissionv1.AdmissionReview,
 
 // validateCoordinator validates configurations for coordinators.
 func validateCoordinator(coordinator *unifflev1alpha1.CoordinatorConfig) error {
-	if len(coordinator.RPCNodePort) != int(*coordinator.Count) ||
-		len(coordinator.HTTPNodePort) != int(*coordinator.Count) {
+	// number of RPCNodePort must equal with number of HTTPNodePort

Review Comment:
   Maybe you could add a unit test for this part of the code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org