You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Thomas Herzog (JIRA)" <ji...@apache.org> on 2012/07/07 21:17:33 UTC

[jira] [Created] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Thomas Herzog created DELTASPIKE-229:
----------------------------------------

             Summary: Add JSFLocaleResolver as an DeaultLocaleResolver
                 Key: DELTASPIKE-229
                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
             Project: DeltaSpike
          Issue Type: New Feature
          Components: I18n-Module
    Affects Versions: 0.2-incubating
            Reporter: Thomas Herzog
             Fix For: 0.4-incubating


Add an JSFLocaleResolver which should get the Locale out of the view root.
For messages used in views this would be fine if delta spike would provide it out of the box.
I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.

This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.

What you think?
Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reassigned DELTASPIKE-229:
----------------------------------------

    Assignee: Mark Struberg
    
> Add JSFLocaleResolver as an DeaultLocaleResolver
> ------------------------------------------------
>
>                 Key: DELTASPIKE-229
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: JSF-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>            Assignee: Mark Struberg
>             Fix For: 0.4-incubating
>
>
> Add an JSFLocaleResolver which should get the Locale out of the view root.
> For messages used in views this would be fine if delta spike would provide it out of the box.
> I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.
> This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
> We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.
> What you think?
> Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved DELTASPIKE-229.
--------------------------------------

    Resolution: Fixed

This got committed as part of DELTASPIKE-281
                
> Add JSFLocaleResolver as an DeaultLocaleResolver
> ------------------------------------------------
>
>                 Key: DELTASPIKE-229
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: JSF-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>            Assignee: Mark Struberg
>             Fix For: 0.4-incubating
>
>
> Add an JSFLocaleResolver which should get the Locale out of the view root.
> For messages used in views this would be fine if delta spike would provide it out of the box.
> I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.
> This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
> We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.
> What you think?
> Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DELTASPIKE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408751#comment-13408751 ] 

Mark Struberg commented on DELTASPIKE-229:
------------------------------------------

that will be part of the JSF module. If present, it will @Specialize the DefaultLocaleResolver
                
> Add JSFLocaleResolver as an DeaultLocaleResolver
> ------------------------------------------------
>
>                 Key: DELTASPIKE-229
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: I18n-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>             Fix For: 0.4-incubating
>
>
> Add an JSFLocaleResolver which should get the Locale out of the view root.
> For messages used in views this would be fine if delta spike would provide it out of the box.
> I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.
> This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
> We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.
> What you think?
> Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DELTASPIKE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408800#comment-13408800 ] 

Gerhard Petracek commented on DELTASPIKE-229:
---------------------------------------------

@ mark: +1 (similar to what we have in myfaces codi)
                
> Add JSFLocaleResolver as an DeaultLocaleResolver
> ------------------------------------------------
>
>                 Key: DELTASPIKE-229
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: I18n-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>             Fix For: 0.4-incubating
>
>
> Add an JSFLocaleResolver which should get the Locale out of the view root.
> For messages used in views this would be fine if delta spike would provide it out of the box.
> I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.
> This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
> We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.
> What you think?
> Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DELTASPIKE-229) Add JSFLocaleResolver as an DeaultLocaleResolver

Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerhard Petracek updated DELTASPIKE-229:
----------------------------------------

    Component/s:     (was: I18n-Module)
                 JSF-Module
    
> Add JSFLocaleResolver as an DeaultLocaleResolver
> ------------------------------------------------
>
>                 Key: DELTASPIKE-229
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-229
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: JSF-Module
>    Affects Versions: 0.2-incubating
>            Reporter: Thomas Herzog
>             Fix For: 0.4-incubating
>
>
> Add an JSFLocaleResolver which should get the Locale out of the view root.
> For messages used in views this would be fine if delta spike would provide it out of the box.
> I know not that much code to write, but still a class more in the source, for a code which nearly every web developer will use, i think.
> This is my opinion, because we set the locale via <f:view locale="#{localeBean.viewLocale}" /> in every view, because we do provide resouce bundles for de_DE, en_US, ... an not for de_AT or de_CH and if we wouldn't do it that way, the request locale would used, and this would result in an MessageBundleNotFoundException. 
> We tried to put the locale in the view root via PhaseListener before, but sometimes EL got evaluated before.
> What you think?
> Do developer get the locale for messages via the view root as we do, or do they get the locale in an different way?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira