You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/10 03:31:05 UTC

[GitHub] [netbeans] mbien commented on pull request #3414: Support for image IDs, LSP client can redefine images/icons

mbien commented on pull request #3414:
URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1008516689


   i am a bit late to the URI vs URL discussion but i only wanted to add that I am avoiding using URLs whenever possible. The class has several non obvious problems, e.g it does dns lookups in the background. This means that equals and hash code has to do IO which causes a chain of issues. All what is needed is someone putting URLs as keys into a map.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists