You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/27 02:14:07 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #17845: [fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction

poorbarcode opened a new pull request, #17845:
URL: https://github.com/apache/pulsar/pull/17845

   Fixes:
   
   - #17755
   
   ### Motivation
   
   Concurrent execution of these two instructions will throw an exception:
   
   - Mocked objects are executing methods
   - Bind the new mock behavior again
   
   In this test, `cursorMock` triggers this error.
   
   ### Modifications
   
   make "binding the new mock behavior" always running after "all methods execute finish"
   
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   
   - https://github.com/poorbarcode/pulsar/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17845: [fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17845:
URL: https://github.com/apache/pulsar/pull/17845#issuecomment-1259457818

   After discussion with @congbobo184 , the scenario of this test was covered by `PendingAckPersistentTest`, so deleted it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17845: [fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17845:
URL: https://github.com/apache/pulsar/pull/17845#issuecomment-1260335907

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #17845: [fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17845:
URL: https://github.com/apache/pulsar/pull/17845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17845: [fix][flaky-test]PersistentSubscriptionTest.testCanAcknowledgeAndCommitForTransaction

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17845:
URL: https://github.com/apache/pulsar/pull/17845#issuecomment-1260294202

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org