You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "wchevreuil (via GitHub)" <gi...@apache.org> on 2026/09/09 16:33:04 UTC
[PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
wchevreuil opened a new pull request, #164:
URL: https://github.com/apache/hbase-connectors/pull/164
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "wchevreuil (via GitHub)" <gi...@apache.org>.
wchevreuil commented on code in PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164#discussion_r3971396281
##########
dev-support/jenkins/Dockerfile:
##########
@@ -17,7 +17,7 @@
# Dockerfile for hbase-connectors pre-commit build.
# https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build
-FROM maven:3.8-jdk-8
+FROM maven:3.8-eclipse-temurin-8
Review Comment:
Sure, let's try 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164#discussion_r3971486670
##########
dev-support/jenkins/Dockerfile:
##########
@@ -17,7 +17,7 @@
# Dockerfile for hbase-connectors pre-commit build.
# https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build
-FROM maven:3.8-jdk-8
+FROM maven:3.8-eclipse-temurin-8
Review Comment:
The `maven:3.9-eclipse-temurin-8` tag is a floating tag and can change over time (including Maven patch updates and base OS changes), which can make CI runs non-reproducible and introduce sudden breakages. Consider pinning to a more specific Maven patch version (and ideally an image digest) to improve build determinism.
##########
dev-support/jenkins/Jenkinsfile:
##########
@@ -40,7 +40,7 @@ pipeline {
YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh"
ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump'
BUILD_URL_ARTIFACTS = "artifact/${WORKDIR_REL}/${PATCH_REL}"
- SET_JAVA_HOME = '/usr/local/openjdk-8'
+ SET_JAVA_HOME = '/opt/java/openjdk'
Review Comment:
Hardcoding `SET_JAVA_HOME` to a specific filesystem path makes the pipeline tightly coupled to the container image layout. If the image already sets `JAVA_HOME`, consider deriving `SET_JAVA_HOME` from `JAVA_HOME` (or documenting why this override is required) to reduce future churn when the base image changes again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164#issuecomment-5605443013
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-164/1/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "taklwu (via GitHub)" <gi...@apache.org>.
taklwu commented on code in PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164#discussion_r3971241016
##########
dev-support/jenkins/Dockerfile:
##########
@@ -17,7 +17,7 @@
# Dockerfile for hbase-connectors pre-commit build.
# https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build
-FROM maven:3.8-jdk-8
+FROM maven:3.8-eclipse-temurin-8
Review Comment:
i'm comparing [3.8.2-eclipse-temurin-8](https://hub.docker.com/layers/library/maven/3.8.2-eclipse-temurin-8/images/sha256-e44d59d780ae2f0f4d9a9c5dc6ffeeda6865b3da7cff92408e702e3dc6ed7b7c) and [3.9-eclipse-temurin-8](https://hub.docker.com/layers/library/maven/3.9-eclipse-temurin-8/images/sha256-a349364bf988dbf1946f9e0fd373361d579b2f750e380dd507d9f063646d68a6)
basically it's latest and more secure release (less 0 high vulnerabilities and only medium vulnerabilities), so can we use maven 3.9 ?
```suggestion
FROM maven:3.9-eclipse-temurin-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164#issuecomment-5606411698
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-164/2/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30374 Update base docker image for hbase-connectors jenkins CI job [hbase-connectors]
Posted by "wchevreuil (via GitHub)" <gi...@apache.org>.
wchevreuil merged PR #164:
URL: https://github.com/apache/hbase-connectors/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org