[GitHub] [skywalking] wu-sheng commented on a change in pull request #8739: Trim tag's key and value in log query.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #8739:
URL: https://github.com/apache/skywalking/pull/8739#discussion_r835043463



##########
File path: oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/LogQuery.java
##########
@@ -61,7 +61,10 @@ public Logs queryLogs(LogQueryCondition condition) throws IOException {
             endSecondTB = condition.getQueryDuration().getEndTimeBucketInSec();
         }
         Order queryOrder = isNull(condition.getQueryOrder()) ? Order.DES : condition.getQueryOrder();
-
+        condition.getTags().forEach(tag -> {

Review comment:
       I think tags could be NULL? All log relative e2e tests are failing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org