You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/03 20:42:00 UTC

[GitHub] [incubator-gobblin] aplex opened a new pull request #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

aplex opened a new pull request #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1014
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
    This script was missing the "die" function that is used for error handling.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] codecov-io commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-570699740
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2858      +/-   ##
   ============================================
   + Coverage     45.72%   45.75%   +0.03%     
   - Complexity     9085     9105      +20     
   ============================================
     Files          1913     1917       +4     
     Lines         72021    72131     +110     
     Branches       7943     7956      +13     
   ============================================
   + Hits          32929    33006      +77     
   - Misses        36074    36100      +26     
   - Partials       3018     3025       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
   | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
   | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
   | [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `77.04% <0%> (ø)` | `11% <0%> (?)` | |
   | [...ion/suite/CompactionWithWatermarkSuiteFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZUZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
   | [.../compaction/verify/CompactionWatermarkChecker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25XYXRlcm1hcmtDaGVja2VyLmphdmE=) | `92.85% <0%> (ø)` | `9% <0%> (?)` | |
   | [...compaction/suite/CompactionWithWatermarkSuite.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
   | [...ta/management/dataset/TimePartitionGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvVGltZVBhcnRpdGlvbkdsb2JGaW5kZXIuamF2YQ==) | `93.61% <0%> (+0.21%)` | `24% <0%> (+1%)` | :arrow_up: |
   | [...gobblin/compaction/mapreduce/MRCompactionTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdGlvblRhc2suamF2YQ==) | `76.19% <0%> (+0.58%)` | `9% <0%> (ø)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=footer). Last update [4483268...26caf4c](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-570699740
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc) will **increase** coverage by `0.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2858      +/-   ##
   ============================================
   + Coverage      44.8%   45.75%   +0.95%     
   - Complexity     8933     9105     +172     
   ============================================
     Files          1917     1917              
     Lines         72131    72131              
     Branches       7956     7956              
   ============================================
   + Hits          32316    33006     +690     
   + Misses        36832    36100     -732     
   - Partials       2983     3025      +42
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
   | [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `47.31% <0%> (+0.48%)` | `29% <0%> (ø)` | :arrow_down: |
   | [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `59.78% <0%> (+0.79%)` | `36% <0%> (+2%)` | :arrow_up: |
   | [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <0%> (+0.83%)` | `68% <0%> (ø)` | :arrow_down: |
   | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
   | [...in/java/org/apache/gobblin/runtime/JobContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSm9iQ29udGV4dC5qYXZh) | `76.37% <0%> (+2.19%)` | `50% <0%> (+1%)` | :arrow_up: |
   | [...va/org/apache/gobblin/runtime/util/JobMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Kb2JNZXRyaWNzLmphdmE=) | `73.68% <0%> (+2.63%)` | `13% <0%> (+1%)` | :arrow_up: |
   | [.../gobblin/runtime/job/JobInterruptionPredicate.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iL0pvYkludGVycnVwdGlvblByZWRpY2F0ZS5qYXZh) | `59.45% <0%> (+2.7%)` | `8% <0%> (+1%)` | :arrow_up: |
   | [...apache/gobblin/runtime/local/LocalJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9jYWwvTG9jYWxKb2JMYXVuY2hlci5qYXZh) | `61.81% <0%> (+3.63%)` | `5% <0%> (+1%)` | :arrow_up: |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=footer). Last update [d18783d...26caf4c](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] shirshanka removed a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
shirshanka removed a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-571271447
 
 
   @htran1 : testing assignment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] shirshanka commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
shirshanka commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-571023938
 
 
   LGTM!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] shirshanka commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
shirshanka commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-571271447
 
 
   @htran1 : testing assignment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-570699740
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc) will **increase** coverage by `0.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2858      +/-   ##
   ============================================
   + Coverage      44.8%   45.75%   +0.95%     
   - Complexity     8933     9105     +172     
   ============================================
     Files          1917     1917              
     Lines         72131    72131              
     Branches       7956     7956              
   ============================================
   + Hits          32316    33006     +690     
   + Misses        36832    36100     -732     
   - Partials       2983     3025      +42
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
   | [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `47.31% <0%> (+0.48%)` | `29% <0%> (ø)` | :arrow_down: |
   | [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `59.78% <0%> (+0.79%)` | `36% <0%> (+2%)` | :arrow_up: |
   | [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <0%> (+0.83%)` | `68% <0%> (ø)` | :arrow_down: |
   | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
   | [...in/java/org/apache/gobblin/runtime/JobContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSm9iQ29udGV4dC5qYXZh) | `76.37% <0%> (+2.19%)` | `50% <0%> (+1%)` | :arrow_up: |
   | [...va/org/apache/gobblin/runtime/util/JobMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Kb2JNZXRyaWNzLmphdmE=) | `73.68% <0%> (+2.63%)` | `13% <0%> (+1%)` | :arrow_up: |
   | [.../gobblin/runtime/job/JobInterruptionPredicate.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iL0pvYkludGVycnVwdGlvblByZWRpY2F0ZS5qYXZh) | `59.45% <0%> (+2.7%)` | `8% <0%> (+1%)` | :arrow_up: |
   | [...apache/gobblin/runtime/local/LocalJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9jYWwvTG9jYWxKb2JMYXVuY2hlci5qYXZh) | `61.81% <0%> (+3.63%)` | `5% <0%> (+1%)` | :arrow_up: |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=footer). Last update [d18783d...26caf4c](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] shirshanka removed a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh

Posted by GitBox <gi...@apache.org>.
shirshanka removed a comment on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-571023938
 
 
   LGTM!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services