You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/07 21:27:56 UTC
[GitHub] [flink] zentol commented on a change in pull request #10364:
[FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters
zentol commented on a change in pull request #10364: [FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters
URL: https://github.com/apache/flink/pull/10364#discussion_r355144392
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -145,7 +147,7 @@ public MetricRegistryImpl(MetricRegistryConfiguration config, Collection<Reporte
} else {
LOG.info("Reporting metrics for reporter {} of type {}.", namedReporter, className);
}
- reporters.add(reporterInstance);
+ reporters.add(new ReporterAndSettings(reporterInstance, new ReporterScopedSettings(reporters.size() - 1)));
Review comment:
I don't think we'll ever need to create this anywhere else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services