You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Bruce J Schuchardt (Jira)" <ji...@apache.org> on 2021/04/07 16:55:00 UTC

[jira] [Created] (GEODE-9128) Remove host name look-up from JGAddress

Bruce J Schuchardt created GEODE-9128:
-----------------------------------------

             Summary: Remove host name look-up from JGAddress
                 Key: GEODE-9128
                 URL: https://issues.apache.org/jira/browse/GEODE-9128
             Project: Geode
          Issue Type: Test
          Components: membership
            Reporter: Bruce J Schuchardt


The method JGAddress.toString() contains a host name lookup that should be removed.  It should just log the toString of its ip_addr field, not ip_addr.getHostName().  That method can cause a reverse-DNS lookup, which is needlessly expensive for a toString() operation.

{code:java}
  public String toString() {
    StringBuilder sb = new StringBuilder();

    if (ip_addr == null)
      sb.append("<null>");
    else {
      sb.append(ip_addr.getHostName());
    }
    if (vmViewId >= 0) {
      sb.append("<v").append(vmViewId).append('>');
    }
    if (SHOW_UUIDS) {
      sb.append("(").append(toStringLong()).append(")");
    } else if (mostSigBits == 0 && leastSigBits == 0) {
      sb.append("(no uuid set)");
    }
    sb.append(":").append(port);
    return sb.toString();
  }
{code:java}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)