You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Maja Kabiljo (JIRA)" <ji...@apache.org> on 2012/11/08 23:18:11 UTC

[jira] [Created] (GIRAPH-414) Create BinaryCombiner ands specialized message store for it

Maja Kabiljo created GIRAPH-414:
-----------------------------------

             Summary: Create BinaryCombiner ands specialized message store for it
                 Key: GIRAPH-414
                 URL: https://issues.apache.org/jira/browse/GIRAPH-414
             Project: Giraph
          Issue Type: Improvement
            Reporter: Maja Kabiljo
            Assignee: Maja Kabiljo


Current combiner interface is very general, but also doesn't provide the best performance. All the combiners we currently have are binary combiners, i.e. they can combine two messages into one. Having a lists around this simple concept makes it slower and requires more object creations.
Adding BinaryCombiner, and a specialized message store which will be used with it. This message store has only one message per vertex instead of having a collection per vertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-414) Create BinaryCombiner ands specialized message store for it

Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494362#comment-13494362 ] 

Avery Ching commented on GIRAPH-414:
------------------------------------

Maja's reviewboard link https://reviews.apache.org/r/7975/
                
> Create BinaryCombiner ands specialized message store for it
> -----------------------------------------------------------
>
>                 Key: GIRAPH-414
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-414
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>
> Current combiner interface is very general, but also doesn't provide the best performance. All the combiners we currently have are binary combiners, i.e. they can combine two messages into one. Having a lists around this simple concept makes it slower and requires more object creations.
> Adding BinaryCombiner, and a specialized message store which will be used with it. This message store has only one message per vertex instead of having a collection per vertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-414) Create BinaryCombiner ands specialized message store for it

Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maja Kabiljo updated GIRAPH-414:
--------------------------------

    Attachment: GIRAPH-414.patch

Thanks Avery, forgot to post it here...
                
> Create BinaryCombiner ands specialized message store for it
> -----------------------------------------------------------
>
>                 Key: GIRAPH-414
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-414
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-414.patch
>
>
> Current combiner interface is very general, but also doesn't provide the best performance. All the combiners we currently have are binary combiners, i.e. they can combine two messages into one. Having a lists around this simple concept makes it slower and requires more object creations.
> Adding BinaryCombiner, and a specialized message store which will be used with it. This message store has only one message per vertex instead of having a collection per vertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-414) Create BinaryCombiner ands specialized message store for it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496490#comment-13496490 ] 

Hudson commented on GIRAPH-414:
-------------------------------

Integrated in Giraph-trunk-Commit #281 (See [https://builds.apache.org/job/Giraph-trunk-Commit/281/])
    GIRAPH-414: Create BinaryCombiner and specialized message store for it (Revision 1408863)

     Result = SUCCESS
maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1408863
Files : 
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphRunner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/messages/CollectionOfMessagesPerVertexStore.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/messages/DiskBackedMessageStore.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/examples/DoubleSumCombiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/examples/MinimumDoubleCombiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspUtils.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/Combiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphTypeValidator.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/VertexCombiner.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/TestVertexTypes.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/ConnectionTest.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/RequestFailureTest.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/RequestTest.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/comm/TestMessageStores.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/utils/MockUtils.java

                
> Create BinaryCombiner ands specialized message store for it
> -----------------------------------------------------------
>
>                 Key: GIRAPH-414
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-414
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-414.patch
>
>
> Current combiner interface is very general, but also doesn't provide the best performance. All the combiners we currently have are binary combiners, i.e. they can combine two messages into one. Having a lists around this simple concept makes it slower and requires more object creations.
> Adding BinaryCombiner, and a specialized message store which will be used with it. This message store has only one message per vertex instead of having a collection per vertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-414) Create BinaryCombiner ands specialized message store for it

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494135#comment-13494135 ] 

Eli Reisman commented on GIRAPH-414:
------------------------------------

Yes! This makes me happy!
                
> Create BinaryCombiner ands specialized message store for it
> -----------------------------------------------------------
>
>                 Key: GIRAPH-414
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-414
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>
> Current combiner interface is very general, but also doesn't provide the best performance. All the combiners we currently have are binary combiners, i.e. they can combine two messages into one. Having a lists around this simple concept makes it slower and requires more object creations.
> Adding BinaryCombiner, and a specialized message store which will be used with it. This message store has only one message per vertex instead of having a collection per vertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira