You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2023/01/03 13:41:30 UTC

[GitHub] [lucene] jpountz commented on pull request #12053: Allow reusing indexed binary fields.

jpountz commented on PR #12053:
URL: https://github.com/apache/lucene/pull/12053#issuecomment-1369783917

   I'm good with adding more validation, I pushed more changes:
    - The Field ctor that takes a BytesRef complains if the field is tokenized or if offsets are indexed.
    - The Field ctor that takes a BytesRef complains if the field is neither indexed, nor docvalued, nor stored.
    - It is no longer possible to configure a TokenStream plus a value on the same field: either the value is a token stream, or it's something else. Otherwise this introduces weird situations, like we only need to tolerate a tokenized binary value if a token stream is configured too.
   
   The last bit makes the change breaking, so I'm targeting 10.0 only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org