You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2014/05/08 15:43:33 UTC
[Bug 56503] New: Ifdefine analysis and variable replacments are in
wrong order
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
Bug ID: 56503
Summary: Ifdefine analysis and variable replacments are in
wrong order
Product: Apache httpd-2
Version: 2.4.9
Hardware: Sun
OS: Solaris
Status: NEW
Severity: minor
Priority: P2
Component: Core
Assignee: bugs@httpd.apache.org
Reporter: inu@inusasha.de
When a variable is not defined and surounded by a IfDefine (on this variable),
a warning is raised, which is not relevant.
This warning should not appear.
The IfDefine-section have to dropped, in front of the variable replacment. (i
think)
Here a simple example.
servername_sso is not defined for this configuration.
# Config
<IfDefine servername_sso>
<VirtualHost *:80>
# intern
ServerName ${servername_sso}
RedirectMatch permanent ^/$ /auth/login/ssointern
RedirectMatch permanent ^/auth/login$ /auth/login/ssointern
</VirtualHost>
</IfDefine>
# ErrorMessage
[core:warn] [pid 7482] AH00111: Config variable ${servername_sso} is not
defined
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
--- Comment #2 from Edward Lu <Ch...@gmail.com> ---
ap_soak_end_container() throws away anything that isn't a "<Container>" or
"</Container>" directive, so the ap_resolve_env() would only have an impact if
a var was defined to one of those. I'm not sure if there's any other use cases
that I'm missing, but simply removing the ap_resolve_env() call doesn't seem
like it would be much of an issue.
An alternative would be to ignore undefined vars in an <IfX> container, but
this would require some restructuring of ap_resolve_env(), which currently
doesn't have a mechanism for that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
Ninos <me...@ninosego.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |me@ninosego.de
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
--- Comment #5 from inu@inusasha.de ---
Ich had tested the httpd 2.4.10 with the given fix on Sparc-Solaris 2.10
Build: fine
Running: fine
(only short time, but is now in our main test-stage)
Parsed Config: fine
is identical between 2.4.9 and 2.4.10+fix
(checked via info_handler output)
Thanks to team :)
Bye,
Sascha
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
--- Comment #3 from Christophe JAILLET <ch...@wanadoo.fr> ---
See https://marc.info/?l=apache-httpd-dev&m=140635726532490&w=2 on httpd-dev
mailing list.
If no response within the coming weeks, I will apply the change to trunk and
propose it to backport for 2.4.x
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
Mike Rumph <mi...@oracle.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Ifdefine analysis and |Ifdefine analysis and
|variable replacments are in |variable replacements are
|wrong order |in wrong order
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
--- Comment #4 from inu@inusasha.de ---
I will try it, this or next week, and give response.
Thanks,
Sascha
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
--- Comment #1 from Christophe JAILLET <ch...@wanadoo.fr> ---
Confirmed.
This is due to a call to 'ap_resolve_env' in 'ap_soak_end_container()'
(config.c)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
Ninos <me...@ninosego.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|me@ninosego.de |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 56503] Ifdefine analysis and variable replacements are in wrong
order
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56503
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Christophe JAILLET <ch...@wanadoo.fr> ---
This has been fixed in 2.4.x in r1621603.
This will be part of 2.4.11
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org