You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/13 19:04:00 UTC

[jira] [Commented] (NIFI-3988) SplitRecord processor missing fragment attributes

    [ https://issues.apache.org/jira/browse/NIFI-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720492#comment-16720492 ] 

ASF GitHub Bot commented on NIFI-3988:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/3217

    NIFI-3988: Add fragment attributes to SplitRecord

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-3988

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3217
    
----
commit 1b95cd85fe623e6f981340dbfdcdc3c1034dbd5d
Author: Matthew Burgess <ma...@...>
Date:   2018-12-13T19:02:14Z

    NIFI-3988: Add fragment attributes to SplitRecord

----


> SplitRecord processor missing fragment attributes
> -------------------------------------------------
>
>                 Key: NIFI-3988
>                 URL: https://issues.apache.org/jira/browse/NIFI-3988
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>         Environment: Fedora 25
>            Reporter: Uwe Geercken
>            Assignee: Matt Burgess
>            Priority: Minor
>              Labels: attributes, processor, split
>
> There are several SplitXXX processors available. They all add some attributes for the relevant fragment to the flowfile. Such as e.g. fragment.index, fragment.count and fragment.identifier.
> The SplitRecord processor does not add these attributes.
> For a consistent user experience, and partly for compatibility with MergeContent and other processors please add the relevant attributes to SplitRecord.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)