You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by "Anatoli Fomenko (JIRA)" <ji...@apache.org> on 2013/05/02 23:58:19 UTC

[jira] [Commented] (BIGTOP-953) Revert BIGTOP-835 and BIGTOP-950

    [ https://issues.apache.org/jira/browse/BIGTOP-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647949#comment-13647949 ] 

Anatoli Fomenko commented on BIGTOP-953:
----------------------------------------

Revert patch produces code that looks identical to pre- BIGTOP-835 and BIGTOP-950.
+1
                
> Revert BIGTOP-835 and BIGTOP-950
> --------------------------------
>
>                 Key: BIGTOP-953
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-953
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.5.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.6.0
>
>         Attachments: BIGTOP-953.patch
>
>
> I have looked more into BIGTOP-950 and BIGTOP-835.
> It seems that the timeout functionality is completely unused in the current Bigtop. So, being badly implemented in the first place, an attempt to fix it - BIGTOP-950 - actually just restored the original behavior that has existed since 2011. 
> Considering all this, I would remove the following SHAs
>   bc49df0bf3ed71dbe7a8ded7857b6087d4df8fd0
>   b5f900efc17c616dc34704cd520285adcd814e9e
> because fixing non-used code doesn't make any sense.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira