[GitHub] [superset] geido commented on a diff in pull request #21269: feat: Adds a helper text option to the Select component

[GitBox <gi...@apache.org>]

geido commented on code in PR #21269:
URL: https://github.com/apache/superset/pull/21269#discussion_r960527594


##########
superset-frontend/src/components/Select/AsyncSelect.test.tsx:
##########
@@ -750,6 +722,20 @@ test('fires a new request if all values have not been fetched', async () => {
   expect(mock).toHaveBeenCalledTimes(2);
 });
 
+test('does not renders a helper text by default', async () => {

Review Comment:
   ```suggestion
   test('does not render a helper text by default', async () => {
   ```



##########
superset-frontend/src/components/Select/Select.test.tsx:
##########
@@ -535,6 +535,20 @@ test('triggers getPopupContainer if passed', async () => {
   expect(getPopupContainer).toHaveBeenCalled();
 });
 
+test('does not renders a helper text by default', async () => {

Review Comment:
   ```suggestion
   test('does not render a helper text by default', async () => {
   ```



##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -162,6 +170,16 @@ const StyledLoadingText = styled.div`
   `}
 `;
 
+const StyledHelperText = styled.div`

Review Comment:
   This looks identical to the AsyncSelect one. Should we put in a common file and import it from there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org