(solr) 02/04: SOLR-18202 Reduce Memory Usage of testSequentialVsParallelFingerprint (#4310)

[ds...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dsmiley pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/solr.git

commit d9fa05d4ca6eac12b479df511697a155f2b08bee
Author: Luke Kot-Zaniewski <lk...@bloomberg.net>
AuthorDate: Wed Apr 29 13:51:25 2026 -0400

    SOLR-18202 Reduce Memory Usage of testSequentialVsParallelFingerprint (#4310)
    
    testSequentialVsParallelFingerprint creates a bunch of segments by design. This creates enormous memory overhead, partly because a new searcher is opened with each commit.
    
    I tried setting openSearcher to false but the RealtimeGetHandler searcher still gets opened and incurs similar memory overhead per commit. I landed on just writing via IW which seems ok for this test. For reference by doing this we reduce the total memory consumption of this test by about 10-20X according to my profiler.
    
    (cherry picked from commit a484172a97d39441bddc8af85eff702856dcc2ba)
---
 .../solr/update/SolrIndexFingerprintTest.java      | 31 ++++++++++++++++------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java b/solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java
index eead5d7441f..8621c33a015 100644
--- a/solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java
+++ b/solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java
@@ -17,11 +17,16 @@
 package org.apache.solr.update;
 
 import java.io.IOException;
-import java.util.stream.IntStream;
+import org.apache.lucene.document.Document;
+import org.apache.lucene.document.Field;
+import org.apache.lucene.document.NumericDocValuesField;
+import org.apache.lucene.document.StringField;
 import org.apache.lucene.index.FilterLeafReader;
+import org.apache.lucene.index.IndexWriter;
 import org.apache.lucene.index.LeafReader;
 import org.apache.solr.SolrTestCaseJ4;
 import org.apache.solr.core.SolrCore;
+import org.apache.solr.util.RefCounted;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
@@ -38,13 +43,23 @@ public class SolrIndexFingerprintTest extends SolrTestCaseJ4 {
     SolrCore core = h.getCore();
 
     int numDocs = RANDOM_MULTIPLIER == 1 ? 3 : 500;
-    // Create a set of many segments (to catch race conditions, i.e. SOLR-17863)
-    IntStream.range(0, numDocs)
-        .forEach(
-            i -> {
-              assertU(adoc("id", "" + i));
-              assertU(commit());
-            });
+    // Create a set of many segments (to catch race conditions, i.e. SOLR-17863).
+    // Write directly to the IndexWriter and flush after each doc to create one segment per doc,
+    // avoiding the overhead of opening a new searcher on every Solr commit.
+    RefCounted<IndexWriter> iwRef = core.getSolrCoreState().getIndexWriter(core);
+    try {
+      IndexWriter writer = iwRef.get();
+      for (int i = 0; i < numDocs; i++) {
+        Document doc = new Document();
+        doc.add(new StringField("id", Integer.toString(i), Field.Store.YES));
+        doc.add(new NumericDocValuesField("_version_", i + 1));
+        writer.addDocument(doc);
+        writer.flush();
+      }
+    } finally {
+      iwRef.decref();
+    }
+    assertU(commit("openSearcher", "true"));
 
     try (var searcher = core.getSearcher().get()) {
       // Compute fingerprint sequentially to compare with parallel computation