You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/03 09:21:48 UTC

[GitHub] [spark] martin-g opened a new pull request #35388: SPARK-38096 [BUILD] Update sbt to 1.6.2

martin-g opened a new pull request #35388:
URL: https://github.com/apache/spark/pull/35388


   ### What changes were proposed in this pull request?
   
   This PR aims to upgrade SBT to 1.6.2.
   
   ### Why are the changes needed?
   
   Sbt 1.6.2 was released with minor improvements - https://eed3si9n.com/sbt-1.6.2
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   GA and AppVeyor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028886115


   > @martin-g mind enabling GitHub Actions in your forked repository?
   
   This was the reason why the first PR failed. Then I've enabled GHA on my fork and restarted the GHA checks by close+reopen the PR, but the AppVeyor check was still seeing the PR as closed. So, I closed the previous PR and opened this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g edited a comment on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028954996


   Thanks for explaining! It seems there were more clicks needed!
   I've enabled all workflows but `Close stale PRs` and `Publish Snapshot `.
   I've just rebased from latest master and force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029040681


   The test seems running fine at https://github.com/martin-g/spark/runs/5051700359. Other builds should not be a matter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029199207


   The last commit passed. Merged to master.
   - https://github.com/martin-g/spark/runs/5051700359
   - https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/42440411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028948980


   Seems like it's disabled in your forked repo. It would have to be enabled (https://github.com/martin-g/spark/actions/workflows/build_and_test.yml):
   
   ![Screen Shot 2022-02-03 at 9 38 07 PM](https://user-images.githubusercontent.com/6477701/152344268-5899781b-2184-4666-8240-c13caf34dce8.png)
   
   Yeah, it passed in AppVeyor (AppVeyor only runs SparkR tests / build in Wondows) but the main build has not actually gotten triggered in GitHub Actions (GitHub Actions runs all other related build, e.g., SBT + mima, SBT + doc generation). I think it's best to make sure the main build passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35388: SPARK-38096 [BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028829046


   @martin-g mind enabling GitHub Actions in your forked repository? See also https://github.com/apache/spark/runs/5049316939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028989492


   Is it expected the build in my fork to fail with:
   ```
   
   2s
   Run echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   From https://github.com/martin-g/spark
    * branch                  master     -> FETCH_HEAD
   Already up to date. (nothing to squash)
   On branch master
   Your branch is up to date with 'origin/master'.
   
   nothing to commit, working tree clean
   Error: Process completed with exit code 1.
   ```
   e.g. https://github.com/martin-g/spark/runs/5052103135?check_suite_focus=true
   It fails because there is nothing to merge at https://github.com/apache/spark/blob/b63a577b656b5fc56feef1666d1f4d1048b945fe/.github/workflows/build_and_test.yml#L119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029040681


   The test seems running fine at https://github.com/martin-g/spark/runs/5051700359. Other builds should be a matter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028946351


   @HyukjinKwon Push empty commit for this PR ? Is it needed ? All seems good here.
   The problematic PR was https://github.com/apache/spark/pull/35387. Its [check](https://github.com/apache/spark/runs/5049316939) failed.
   But all checks for this PR passed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028954391


   👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028831604


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028948980


   Seems like it's disabled in your forked repo (https://github.com/martin-g/spark/actions/workflows/build_and_test.yml):
   
   ![Screen Shot 2022-02-03 at 9 38 07 PM](https://user-images.githubusercontent.com/6477701/152344268-5899781b-2184-4666-8240-c13caf34dce8.png)
   
   Yeah, it passed in AppVeyor but the main build has not actually got triggered. I think it's best to make sure the main build passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028954996


   Thanks for explaining! It seems there were more clicks needed!
   I've enabled all workflows but `Close stale PRs` and `Publish Snapshot `.
   I've just rebased from laster master and force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35388:
URL: https://github.com/apache/spark/pull/35388


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] martin-g commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029047880


   https://github.com/martin-g/spark/runs/5051700359 started earlier. Its job `Sync the current branch with the latest in Apache Spark` started at `Thu, 03 Feb 2022 12:46:10 GMT` and merged few files:
   ```
   Thu, 03 Feb 2022 12:46:10 GMT
   Run echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   Thu, 03 Feb 2022 12:46:10 GMT From https://github.com/martin-g/spark
   Thu, 03 Feb 2022 12:46:10 GMT  * branch                  sbt-1.6.2  -> FETCH_HEAD
   Thu, 03 Feb 2022 12:46:11 GMT Updating 6347857f0b..2a04a12f29
   Thu, 03 Feb 2022 12:46:11 GMT Fast-forward
   Thu, 03 Feb 2022 12:46:11 GMT Squash commit -- not updating HEAD
   Thu, 03 Feb 2022 12:46:11 GMT  dev/appveyor-install-dependencies.ps1 | 2 +-
   Thu, 03 Feb 2022 12:46:11 GMT  project/build.properties              | 2 +-
   Thu, 03 Feb 2022 12:46:11 GMT  2 files changed, 2 insertions(+), 2 deletions(-)
   Thu, 03 Feb 2022 12:46:11 GMT [master 5d149ac393] Merged commit
   Thu, 03 Feb 2022 12:46:11 GMT  2 files changed, 2 insertions(+), 2 deletions(-)
   ```
   
   but https://github.com/martin-g/spark/runs/5052103135?check_suite_focus=true had nothing to merge and failed:
   ```
   Thu, 03 Feb 2022 13:20:01 GMT
   Run echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   Thu, 03 Feb 2022 13:20:02 GMT From https://github.com/martin-g/spark
   Thu, 03 Feb 2022 13:20:02 GMT  * branch                  master     -> FETCH_HEAD
   Thu, 03 Feb 2022 13:20:02 GMT Already up to date. (nothing to squash)
   Thu, 03 Feb 2022 13:20:03 GMT On branch master
   Thu, 03 Feb 2022 13:20:03 GMT Your branch is up to date with 'origin/master'.
   Thu, 03 Feb 2022 13:20:03 GMT
   Thu, 03 Feb 2022 13:20:03 GMT nothing to commit, working tree clean
   Thu, 03 Feb 2022 13:20:03 GMT Error: Process completed with exit code 1.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028948980


   Seems like it's disabled in your forked repo (https://github.com/martin-g/spark/actions/workflows/build_and_test.yml):
   
   ![Screen Shot 2022-02-03 at 9 38 07 PM](https://user-images.githubusercontent.com/6477701/152344268-5899781b-2184-4666-8240-c13caf34dce8.png)
   
   Yeah, it passed in AppVeyor (AppVeyor only runs SparkR tests / build in Wondows) but the main build has not actually gotten triggered in GitHub Actions (GitHub Actions runs all other related build, e.g., SBT + mima, SBT + doc generation). I think it's best to make sure the main build passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1028928241


   Ah, I see. Do you mind rebasing or pushing an empty commit e.g., `git commit --allow-empty`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029201804


   Welcome to the Apache Spark community, @martin-g .
   I added you to the Apache Spark contributor group and assigned SPARK-38096 to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #35388: [SPARK-38096][BUILD] Update sbt to 1.6.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35388:
URL: https://github.com/apache/spark/pull/35388#issuecomment-1029199207


   The last commit passed. Merged to master.
   - https://github.com/martin-g/spark/runs/5051700359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org