You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/01/18 22:32:26 UTC

[kudu-CR] De-flake heacy-update-compaction-itest

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9067

to review the following change.


Change subject: De-flake heacy-update-compaction-itest
......................................................................

De-flake heacy-update-compaction-itest

Validated with 100 runs on dist-test with 8 stress threads.

Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
---
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/9067/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Gerrit-Change-Number: 9067
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] De-flake heavy-update-compaction-itest

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9067 )

Change subject: De-flake heavy-update-compaction-itest
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Gerrit-Change-Number: 9067
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 19 Jan 2018 02:42:03 +0000
Gerrit-HasComments: No

[kudu-CR] De-flake heavy-update-compaction-itest

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9067

to look at the new patch set (#2).

Change subject: De-flake heavy-update-compaction-itest
......................................................................

De-flake heavy-update-compaction-itest

Validated with 100 runs on dist-test with 8 stress threads.

Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
---
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/9067/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Gerrit-Change-Number: 9067
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] De-flake heavy-update-compaction-itest

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9067 )

Change subject: De-flake heavy-update-compaction-itest
......................................................................

De-flake heavy-update-compaction-itest

Validated with 100 runs on dist-test with 8 stress threads.

Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Reviewed-on: http://gerrit.cloudera.org:8080/9067
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  David Ribeiro Alves: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Gerrit-Change-Number: 9067
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] De-flake heavy-update-compaction-itest

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9067

to look at the new patch set (#3).

Change subject: De-flake heavy-update-compaction-itest
......................................................................

De-flake heavy-update-compaction-itest

Validated with 100 runs on dist-test with 8 stress threads.

Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
---
M src/kudu/integration-tests/heavy-update-compaction-itest.cc
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/9067/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2be0b12c010e991ee05ffbbb0c433c6ca1a8d8e7
Gerrit-Change-Number: 9067
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>