You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2024/06/14 02:49:54 UTC

[PR] [CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup [celeborn]

cfmcgrady opened a new pull request, #2565:
URL: https://github.com/apache/celeborn/pull/2565

   ### What changes were proposed in this pull request?
   
   backport https://github.com/apache/celeborn/pull/2553 to `branch-0.4`
   
   Avoid NPE during shuffle data cleanup by checking for null LevelDB.
   
   ### Why are the changes needed?
   If the LevelDB in StorageManager fails to initialize, the db will be null. This will cause a java.lang.NullPointerException when storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys) is called, and the shuffle data in expiredShuffleKeys will not be cleaned up. The worker's disk may be filled up as a result.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   Manual Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup [celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2565: [CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup
URL: https://github.com/apache/celeborn/pull/2565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup [celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2565:
URL: https://github.com/apache/celeborn/pull/2565#issuecomment-2167364309

   thanks, merging to branch-0.4(v0.4.2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org