You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kh...@apache.org on 2018/01/12 16:43:29 UTC
[geode] branch develop updated: GEODE-4101: Remove test assertions
that mask failure information (#1276)
This is an automated email from the ASF dual-hosted git repository.
khowe pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new bed35d3 GEODE-4101: Remove test assertions that mask failure information (#1276)
bed35d3 is described below
commit bed35d3dc72fc7ae5fac95ce9155d5e4a708a6c2
Author: Kenneth Howe <kh...@pivotal.io>
AuthorDate: Fri Jan 12 08:43:27 2018 -0800
GEODE-4101: Remove test assertions that mask failure information (#1276)
StartServerCommandTest failed in CI build, but the assertion caused an
early failure. By removing this assertion the comparison of expected and
actual command line elements can proceed show where the problem is.
---
.../geode/management/internal/cli/commands/StartLocatorCommandTest.java | 1 -
.../geode/management/internal/cli/commands/StartServerCommandTest.java | 1 -
2 files changed, 2 deletions(-)
diff --git a/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandTest.java b/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandTest.java
index 4d15368..491334d 100644
--- a/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandTest.java
+++ b/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandTest.java
@@ -246,7 +246,6 @@ public class StartLocatorCommandTest {
assertNotNull(commandLineElements);
assertTrue(commandLineElements.length > 0);
- assertEquals(commandLineElements.length, expectedCommandLineElements.size());
for (String commandLineElement : commandLineElements) {
expectedCommandLineElements.remove(commandLineElement);
diff --git a/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandTest.java b/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandTest.java
index 5008ed3..b996a13 100644
--- a/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandTest.java
+++ b/geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandTest.java
@@ -231,7 +231,6 @@ public class StartServerCommandTest {
assertNotNull(commandLineElements);
assertTrue(commandLineElements.length > 0);
- assertEquals(commandLineElements.length, expectedCommandLineElements.size());
for (String commandLineElement : commandLineElements) {
expectedCommandLineElements.remove(commandLineElement);
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].