You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/01/02 12:22:14 UTC
Review Request 55119: Store LogSearch truststore/keystore passwords
in file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55119/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-19333
https://issues.apache.org/jira/browse/AMBARI-19333
Repository: ambari
Description
-------
Strore logsearch keystore/truststore password in a file. (istead of using it as an environment variable in the start script)
file persmissions for passwords are 600. so not encrypted (maybe it can be in the future, but not urgent)
The change does not contain any ambari credential store solution. (that is something on ambari side, this solution is mainly for logsearch side)
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java 614e91e
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java 7a93305
ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 1204ef3
ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2c2d056
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 4d751ba
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 874b90b
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 a179983
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py c3e8930
ambari-server/src/test/python/stacks/2.4/configs/default.json 7591adb
Diff: https://reviews.apache.org/r/55119/diff/
Testing
-------
testing done
Thanks,
Oliver Szabo
Re: Review Request 55119: Store LogSearch truststore/keystore
passwords in file
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55119/#review160363
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Jan. 2, 2017, 12:22 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55119/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 12:22 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19333
> https://issues.apache.org/jira/browse/AMBARI-19333
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Strore logsearch keystore/truststore password in a file. (istead of using it as an environment variable in the start script)
> file persmissions for passwords are 600. so not encrypted (maybe it can be in the future, but not urgent)
>
> The change does not contain any ambari credential store solution. (that is something on ambari side, this solution is mainly for logsearch side)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java 614e91e
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java 7a93305
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 1204ef3
> ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2c2d056
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 4d751ba
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 874b90b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 a179983
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py c3e8930
> ambari-server/src/test/python/stacks/2.4/configs/default.json 7591adb
>
> Diff: https://reviews.apache.org/r/55119/diff/
>
>
> Testing
> -------
>
> testing done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 55119: Store LogSearch truststore/keystore
passwords in file
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55119/#review160386
-----------------------------------------------------------
Ship it!
This looks fine to me.
Could you also add rlevas to this review?
Thanks.
- Robert Nettleton
On Jan. 2, 2017, 12:22 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55119/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 12:22 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19333
> https://issues.apache.org/jira/browse/AMBARI-19333
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Strore logsearch keystore/truststore password in a file. (istead of using it as an environment variable in the start script)
> file persmissions for passwords are 600. so not encrypted (maybe it can be in the future, but not urgent)
>
> The change does not contain any ambari credential store solution. (that is something on ambari side, this solution is mainly for logsearch side)
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java 614e91e
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java 7a93305
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 1204ef3
> ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2c2d056
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 4d751ba
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 874b90b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 a179983
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py c3e8930
> ambari-server/src/test/python/stacks/2.4/configs/default.json 7591adb
>
> Diff: https://reviews.apache.org/r/55119/diff/
>
>
> Testing
> -------
>
> testing done
>
>
> Thanks,
>
> Oliver Szabo
>
>