[GitHub] [airflow] ashb opened a new pull request #5125: [AIRFLOW-4341] Remove `View.render()` already exists in fab.BaseView

[GitBox <gi...@apache.org>]

ashb opened a new pull request #5125: [AIRFLOW-4341] Remove `View.render()` already exists in fab.BaseView
URL: https://github.com/apache/airflow/pull/5125
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4341
    
   
   ### Description
   
   - [x] This behaviour is exactly what the fab.BaseView.render_template function
   already does, and since that exists it makes more sense to use that than
   define our own function
   ### Tests
   
   - [x] Existing tests will cover this
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services