You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2022/12/27 23:07:00 UTC

[jira] [Resolved] (YUNIKORN-1438) remove deprecated linters

     [ https://issues.apache.org/jira/browse/YUNIKORN-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-1438.
---------------------------------------------
    Fix Version/s: 1.2.0
       Resolution: Fixed

golangci linter updated and the dead linters removed from both core and shim

> remove deprecated linters
> -------------------------
>
>                 Key: YUNIKORN-1438
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1438
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: core - common, shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Ting Yao,Huang
>            Priority: Minor
>              Labels: newbie, pull-request-available
>             Fix For: 1.2.0
>
>
> The following linterns have been [deprecated|https://github.com/golangci/golangci-lint/issues/1841] and should be removed from the .golangci.yml file:
>  * deadcode
>  * varcheck
>  * structcheck
> The same checks are included in the linter unused which we already run.
> We do need to clean up the nolint directives that reference these 3 linters. Only structcheck seems to be referenced in the code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org