[GitHub] [hadoop] 9uapaw commented on a diff in pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

[GitBox <gi...@apache.org>]

9uapaw commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r934578071


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -531,6 +531,9 @@ public float getMaximumApplicationMasterResourcePerQueuePercent(String queue) {
     		getMaximumApplicationMasterResourcePercent());
   }
 
+  public boolean isMaximumApplicationMasterResourcePerQueuePercentPresent(String queue) {

Review Comment:
   isMaximumApplicationMasterResourcePerQueuePercentSet would be a better name for this.



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -742,6 +745,10 @@ public float getUserLimitFactor(String queue) {
     return userLimitFactor;
   }
 
+  public boolean isUserLimitFactorPresent(String queue) {

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org