You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/10/30 04:12:12 UTC
Review Request 39800: Fix HDFS du output parsing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3605
https://issues.apache.org/jira/browse/MESOS-3605
Repository: mesos
Description
-------
- Swallow WARN log messages unless the command failed or we could
not parse the output.
- Make the actual du output parsing more reliable by not using
human-readable format, scanning all the output lines, and
tokenizing rather than splitting the output lines.
Diffs
-----
src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/39800/diff/
Testing
-------
make check. Manual testing with a framework that uses the fetcher with HDFS urls.
Thanks,
James Peach
Re: Review Request 39800: Fix HDFS du output parsing.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/#review105031
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Oct. 30, 2015, 3:12 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39800/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 3:12 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3605
> https://issues.apache.org/jira/browse/MESOS-3605
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Swallow WARN log messages unless the command failed or we could
> not parse the output.
> - Make the actual du output parsing more reliable by not using
> human-readable format, scanning all the output lines, and
> tokenizing rather than splitting the output lines.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/39800/diff/
>
>
> Testing
> -------
>
> make check. Manual testing with a framework that uses the fetcher with HDFS urls.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39800: Fix HDFS du output parsing.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/#review104520
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Oct. 30, 2015, 3:12 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39800/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 3:12 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3605
> https://issues.apache.org/jira/browse/MESOS-3605
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Swallow WARN log messages unless the command failed or we could
> not parse the output.
> - Make the actual du output parsing more reliable by not using
> human-readable format, scanning all the output lines, and
> tokenizing rather than splitting the output lines.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/39800/diff/
>
>
> Testing
> -------
>
> make check. Manual testing with a framework that uses the fetcher with HDFS urls.
>
>
> Thanks,
>
> James Peach
>
>