You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2019/08/25 03:57:02 UTC
[hbase] branch branch-2 updated: HBASE-22904 NPE occurs when RS
send space quota usage report during HMaster init (#529)
This is an automated email from the ASF dual-hosted git repository.
stack pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new 5a1603f HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init (#529)
5a1603f is described below
commit 5a1603f2ba8c97103c9415f7fb3be93c6a23e1a3
Author: Pankaj <pa...@huawei.com>
AuthorDate: Sun Aug 25 09:26:20 2019 +0530
HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init (#529)
* NPE occurs when RS send space quota usage report during HMaster init
* Added the debug log
Signed-off-by: Sakthi <sa...@apache.org>
Signed-off-by: stack <st...@apache.org>
---
.../apache/hadoop/hbase/master/MasterRpcServices.java | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
index ed64a3b..3352fd1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
@@ -2209,10 +2209,15 @@ public class MasterRpcServices extends RSRpcServices
return RegionSpaceUseReportResponse.newBuilder().build();
}
MasterQuotaManager quotaManager = this.master.getMasterQuotaManager();
- final long now = EnvironmentEdgeManager.currentTime();
- for (RegionSpaceUse report : request.getSpaceUseList()) {
- quotaManager.addRegionSize(ProtobufUtil.toRegionInfo(
- report.getRegionInfo()), report.getRegionSize(), now);
+ if (quotaManager != null) {
+ final long now = EnvironmentEdgeManager.currentTime();
+ for (RegionSpaceUse report : request.getSpaceUseList()) {
+ quotaManager.addRegionSize(ProtobufUtil.toRegionInfo(report.getRegionInfo()),
+ report.getRegionSize(), now);
+ }
+ } else {
+ LOG.debug(
+ "Received region space usage report but HMaster is not ready to process it, skipping");
}
return RegionSpaceUseReportResponse.newBuilder().build();
} catch (Exception e) {
@@ -2247,6 +2252,9 @@ public class MasterRpcServices extends RSRpcServices
.setSize(tableSize.getValue()).build());
}
return builder.build();
+ } else {
+ LOG.debug(
+ "Received space quota region size report but HMaster is not ready to process it, skipping");
}
return builder.build();
} catch (Exception e) {