You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 06:15:53 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #10934: Fixed #fixed incorrect use toString method.
eolivelli commented on a change in pull request #10934:
URL: https://github.com/apache/pulsar/pull/10934#discussion_r657655082
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java
##########
@@ -414,7 +414,7 @@ private int consumeFromWebSocket(String topic) {
LOG.debug("No message to consume after waiting for 5 seconds.");
} else {
try {
- System.out.println(Base64.getDecoder().decode(msg));
+ System.out.println(Arrays.toString(Base64.getDecoder().decode(msg))); // print decode
Review comment:
Arrays.toString of a byte[] is still not very useful most of the times
in other commands in the pulsar-client we have an option to print byte[] in hex
https://github.com/apache/pulsar/blob/27156e4866298c44e83724eeb10a4ee67317433c/pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java#L100
can you please implement the support for 'displayHex' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org